1.9 by ritch · Pull Request #272 · strongloop/loopback

ritch · 2014-05-21T21:59:39Z

Breaking Changes

See https://github.com/strongloop/loopback/blob/1.9/CHANGES.md for my notes on breaking changes.

Should we mark these in the docs as deprecated?

Model => DataModel

Model is now specifically for defining data structures. DataModel is the default class for app.model(name, ...); and models.json.

Remote Methods

Remote methods no longer rely on function objects for storing meta-data. This means remoting meta-data is simple to (de)serialize. All metadata has been moved from juggler to loopback including the relations.

Types

Remote methods now define the concrete type for accepts / returns. This is required to correctly serialize models when code expects the concrete type (eg. MyModel) in a callback. This is to allow code like the following to work anywhere (client, server, browser, etc)

MyModel.find(function(err, myModel) {
  myModel.name = 'foobar';
  myModel.save();
});

Replication

This has been mostly reviewed as part of #153. End to end tests should be review and glaring issues preventing releasing 1.9.0. Minor issues can be resolved in 1.9.x.

The e2e tests could be improved quite a bit. Suggestions welcome there.

Remote Connector

This has been reworked a little, could use some second eyes. Same story here, anything major should be fixed before we release 1.9.0. Minor changes can be saved 1.9.x.

Isomorphic LoopBack

This feature was landed a while ago, overall testing strategy could use some eyes. Changes suggested here will most likely wait for 1.9.1.

- Move DataModel remoting setup into setup phase - Add a remoting type converter for DataModels - Move model tests into re-usable test utilities - Move other test utilities into new test utilities folder

…into feature/replication

creating a cache - Use the SharedClass class to build the remote connector - Change default base model from Model to DataModel - Fix DataModel errors not logging correct method names - Use the strong-remoting 1.4 resolver API to resolve dynamic remote methods (relation api) - Remove use of fn object for storing remoting meta data

Allow juggler to mix in these methods.

slnode · 2014-05-21T22:27:33Z

Test Failed. To trigger a build add comment - ".test\W+please"
Refer to this link for build results: http://ci.strongloop.com/job/loopback/1282/

slnode · 2014-05-21T22:45:18Z

Test Failed. To trigger a build add comment - ".test\W+please"
Refer to this link for build results: http://ci.strongloop.com/job/loopback/1283/

bajtos · 2014-05-22T08:44:55Z

The sample app hangs after the last step was executed.

I'd say the interval should be cleared when there are no more steps to run.

bajtos · 2014-05-22T09:04:34Z

I am worried about the implications of the change from Model to DataModel on backwards compatibility.

The fact that you are changing base classes of built-in models like User indicates this change is breaking backwards compatibility, as all existing loopback applications calling Model.extend have to be changed to DataModel.extend. Please correct me if I am wrong.

It took me some time to figure out what is the difference between Model and DataModel and I already know a lot about LoopBack internals. Regular loopback users won't be able to figure this out themselves.

The document Changes.md should explain why this change was made, what is the difference between Model and DataModel, when to use which one and most importantly, how this change affects existing application and what steps should be made to fix possible incompatibilities.

bajtos · 2014-05-22T09:16:56Z

One more thing: I find it rather confusing that loopback.createModel is using DataModel instead of Model as the base class.

It is also changing the behaviour of existing apps, consider the following example:

// mqtt is a connector sending messages to an IoT device
var mqtt = loopback.createDataSource('mqtt', { connector: 'mqtt', /* etc. */});
// Message is representing the payload to send. It does not have DAO methods.
var Message = loopback.createModel('message', /* etc. */);
Message.attachTo(mqtt);

Here is my proposal:

Preserve 100% backwards compatibility. Keep loopback.createModel the same as it is. Make sure that when a Model is attached to a datasource, CRUD operations works correctly.
To enable advanced features like sync, ask developers to change their model definition and set DataModel as the base class where appropriate.

If that's not possible, then I am afraid this change should be released as loopback 2.x.

bajtos · 2014-05-22T09:20:02Z

Another idea: for models created via models.json, we can detect what datasource they are being attached to and use the appropriate base class (DataModel for database-like datasources, Model for other kinds).

bajtos · 2014-05-22T10:33:59Z

The name DataModel does not capture the distinction from Model very well. Can we come up with a better name, e.g. CrudModel?

bajtos · 2014-05-22T10:39:00Z

Is trackChanges used by Model at all? Isn't it an option of DataModel only?

ritch · 2014-05-23T18:47:23Z

Closed in favor of: #276

ritch and others added 30 commits January 26, 2014 13:20

Add Change model

4be3395

Add Checkpoint model and Model replication methods

1a13a8d

Add replication example

2582c3f

Add model tests

a0e595d

Add Change model

cc49d67

Add Checkpoint model and Model replication methods

e3d8005

Add replication example

ab8d1ae

Add model tests

13f6738

fixup! rename Change.track => rectifyModelChanges

0bf7af1

fixup! Assert model exists

867e3ca

Merge branch master

e86a00d

Add replication e2e tests

b660f8a

Merge

83e74ab

Fixes for e2e replication / remote connector tests

e35309b

!fixup .replicate() argument handling

69cd6a8

Refactor DataModel remoting

918596f

- Move DataModel remoting setup into setup phase - Add a remoting type converter for DataModels - Move model tests into re-usable test utilities - Move other test utilities into new test utilities folder

Add missing test/model file

1c7527a

!fixup RemoteConnector tests

012f880

fixup! unskip failing tests

e026a7f

!fixup use DataModel instead of Model for all data based models

ae2fb9d

All tests passing

f8b5fa1

Move replication implementation to DataModel

a3a6828

!fixup Test cleanup

5bf1f76

Fix issues when using MongoDB for replication

9082214

Add error logging for missing data

4bab424

Change#getModel(), Doc cleanup, Conflict event

1e2ad9f

Merge branch 'master' into feature/replication

64ea805

bump juggler version

344601c

Rework replication test

d875c51

Rework replication test

2f21f4e

ritch added 14 commits May 15, 2014 17:31

Merge branch 'feature/replication' of github.com:strongloop/loopback …

d58df51

…into feature/replication

Add test for conflicts where both deleted

4d5e788

In progress: rework remoting meta-data

558ea60

Rework change conflict detection

2de33d4

Remove un-rectify-able changes

52eb72d

Ensure changes are created in sync

77bd77e

!fixup Mark DAO methods as delegate

1a8ba60

Allow juggler to mix in these methods.

Depend on juggler@1.6.0

0c925f7

Merge latest from master

d237ae5

Add RC version

7a7f868

Merge in 1.8.3

22670c7

Fix callback reference

90bdc73

Cleanup CHANGES.md

1603a3e

bajtos reviewed May 22, 2014
View reviewed changes

Comment thread lib/models/model.js

bajtos May 22, 2014

Copy link
Copy Markdown

Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is trackChanges used by Model at all? Isn't it an option of DataModel only?

ritch closed this May 23, 2014

ritch mentioned this pull request May 23, 2014

2.0 #276

Merged

33 tasks

bajtos mentioned this pull request Jul 22, 2014

Leftovers from 2.0 #391

Closed

47 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

1.9 - #272

1.9#272
ritch wants to merge 44 commits into
masterfrom
1.9

ritch commented May 21, 2014

Uh oh!

slnode commented May 21, 2014

Uh oh!

slnode commented May 21, 2014

Uh oh!

bajtos May 22, 2014

Uh oh!

bajtos commented May 22, 2014

Uh oh!

bajtos commented May 22, 2014

Uh oh!

bajtos commented May 22, 2014

Uh oh!

bajtos commented May 22, 2014

Uh oh!

bajtos May 22, 2014

Uh oh!

ritch commented May 23, 2014

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Uh oh!

Conversation

ritch commented May 21, 2014

Breaking Changes

Model => DataModel

Remote Methods

Replication

Remote Connector

Isomorphic LoopBack

Uh oh!

slnode commented May 21, 2014

Uh oh!

slnode commented May 21, 2014

Uh oh!

bajtos May 22, 2014

Choose a reason for hiding this comment

Uh oh!

bajtos commented May 22, 2014

Uh oh!

bajtos commented May 22, 2014

Uh oh!

bajtos commented May 22, 2014

Uh oh!

bajtos commented May 22, 2014

Uh oh!

bajtos May 22, 2014

Choose a reason for hiding this comment

Uh oh!

ritch commented May 23, 2014

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants